Use ResizeObserver for responsive charts - #8017
Open
Lexachoc wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
I also want to confirm this description; it seems this option still exists in v4: plotly.js/src/plot_api/plot_config.js Lines 127 to 134 in acddada |
Contributor
Author
|
There is one failed check:
I'm not sure whether this is related to my changes. If it is, how should I address it, or can it be ignored? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original discussion: plotly/react-plotly.js#380
Related PR: plotly/react-plotly.js#379
This is a follow-up to #2974.
Based on plotly/react-plotly.js#380 (comment), I'm opening this PR in plotly.js as well so
config.responsivecan use ResizeObserver directly.